Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package after v0.2.0 release #964

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Update package after v0.2.0 release #964

merged 6 commits into from
Aug 31, 2023

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented Aug 30, 2023

No description provided.

@rasolca rasolca added this to the release v0.2.0 milestone Aug 30, 2023
albestro
albestro approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

✅ SHA verified for 0.2.0

msimberg
msimberg approved these changes Aug 30, 2023
View reviewed changes
spack/packages/dla-future/package.py Outdated Show resolved Hide resolved
@rasolca
Copy link
Collaborator Author

rasolca commented Aug 30, 2023

cscs-ci run

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #964 (0f05437) into master (e52fde5) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         143      143           
  Lines        8681     8681           
  Branches     1112     1112           
=======================================
  Hits         8119     8119           
  Misses        376      376           
  Partials      186      186

aurianer
aurianer approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but is this if needed if we use define_from_variant?

@rasolca
Copy link
Collaborator Author

rasolca commented Aug 31, 2023

cscs-ci run

@aurianer I removed the if you pointed at, However, as the PR in spack was merged already, I will mirror the change in the spack repo, during the next release.

@rasolca rasolca merged commit f467da9 into master Aug 31, 2023
3 checks passed
@rasolca rasolca deleted the rasolca/spack branch August 31, 2023 13:15
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@rasolca
Doc Update package after v0.2.0 release (#964)
0dbcc6f
@rasolca rasolca mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@albestro albestro albestro approved these changes

@msimberg msimberg msimberg approved these changes

@RMeli RMeli Awaiting requested review from RMeli

Assignees
No one assigned
Labels
Priority:High Type:Release
Projects
DLA-F Planning
Archived in project
Milestone
release v0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rasolca @codecov-commenter @msimberg @albestro @aurianer